Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter on Admin page fixed when filter selected and removed #1422

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Sep 18, 2024

Summary of issue

After filtering streetcodes by status admin can`t go back to the whole list of Streetcodes neither deleting data in 'Статус стріткодів' field nor clicking on 'Стріткоди' tub. The only way go back to the whole list is to choose different from 'Стріткоди' tub (e.g 'Партнери', 'Едітор') and then click on 'Стріткоди' tub

Summary of change

Now admin can remove status filter and search will work properly

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@mythter mythter requested review from Michael-Kolpakov, DDeviak and a team September 18, 2024 13:08
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
10.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mythter mythter self-assigned this Sep 29, 2024
@mythter mythter requested a review from a team September 29, 2024 17:01
Copy link
Contributor

@sashapanasiuk5 sashapanasiuk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant go back to the whole list of streetcode by clicking on 'Streetcode' tab

@mythter
Copy link
Contributor Author

mythter commented Sep 30, 2024

I cant go back to the whole list of streetcode by clicking on 'Streetcode' tab

Yes, this is another issue that was fixed in this PR

@mythter mythter merged commit 457cc71 into release/1.1.0 Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants